Re: [tpmdd-devel] [PATCH] tpm: fix multiple race conditions in tpm_ppi.c

[Jason Gunthorpe]

On Tue, Oct 21, 2014 at 11:22:41AM +0300, Jarkko Sakkinen wrote:
> * Traversal of the ACPI device tree was not done right. It should lookup
>   PPI only under the ACPI device that it is associated. Otherwise, it could
>   match to a wrong PPI interface if there are two TPM devices in the device
>   tree.
> * Removed global ACPI handle and version string from tpm_ppi.c as this
>   is racy. Instead they should be associated with the chip.
> * Moved code just a tiny bit towards two-phase allocation to implement
>   fix for the PPI race conditions.
> * Added missing copyright platter in tpm_ppi.c.

The PPI parts of this look fine to me, and are a really nice cleanup,
thanks!

Personally, I'd sequence this commit right after your 'tpm: two-phase
chip management functions' commit because it makes it much saner (no
half step toward the new functions). I assume this is a theoretical
problem? Or do you have a two TPM system?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/