Re: [PATCH v2 01/47] kernel: Add support for poweroff handler call chain

[Guenter Roeck]

On 10/21/2014 03:30 AM, Lee Jones wrote:
> On Tue, 21 Oct 2014, Johan Hovold wrote:
>
> > On Mon, Oct 20, 2014 at 09:12:17PM -0700, Guenter Roeck wrote:
> >
> > > v2:
> > > - poweroff -> power_off
> >
> > Do you want to stick to power[-_ ]off consistently throughout?
>
> I guess you'll want to fix all of these before I review the MFD
> patches?
>
> > > - Add defines for default priorities
> > > - Use raw notifiers protected by spinlocks instead of atomic notifiers
> > > - Add register_poweroff_handler_simple
> > > - Add devm_register_power_off_handler
> > >
> > >   include/linux/pm.h              |  22 ++++
> > >   kernel/power/Makefile           |   1 +
> > >   kernel/power/poweroff_handler.c | 252 ++++++++++++++++++++++++++++++++++++++++
> > >   3 files changed, 275 insertions(+)
> > >   create mode 100644 kernel/power/poweroff_handler.c
> > >
> > > diff --git a/include/linux/pm.h b/include/linux/pm.h
> > > index 383fd68..7e0cb36 100644
> > > --- a/include/linux/pm.h
> > > +++ b/include/linux/pm.h
> > > @@ -34,7 +34,29 @@
> > >   extern void (*pm_power_off)(void);
> > >   extern void (*pm_power_off_prepare)(void);
> > >
> > > +/*
> > > + * Callbacks to manage poweroff handlers
> >
> > power-off
>
> power_off, no?
That is describing text, so hopefully I can use real words here and
don't have to use a term derived from variable and function names.

Sure, I can change poweroff in all describing text to power-off
if that is preferred, no big deal.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/