[PATCH] ucc_geth: invalid rx checksum error values

From: Kokoris, Ioannis
Date: Wed Oct 22 2014 - 09:14:45 EST


Hi,

The value in QE UCC ethernet interfaces shows random values:

# ethtool -S eth0
NIC statistics:
...
rx-ip-checksum-errors: 3933892214

The problem is located in a mismatch between the rx_fw_stat_gstrings fields
- used in ucc_geth_ethtool - and the ucc_geth_rx_firmware_statistics_pram
fields - used in ucc_geth.
Although the QE UCC Ethernet Controller includes the Rx checksum error
counter in the 'Rx firmware counters', the related field is missing from the
ucc_geth driver.
After adding the RxChecksumError field in
ucc_geth_rx_firmware_statistics_pram structure the counter works fine.



Signed-off-by: Ioannis Kokkoris <ioannis.kokoris@xxxxxxxxx>


diff -Nru a/drivers/net/ethernet/freescale/ucc_geth.h
b/drivers/net/ethernet/freescale/ucc_geth.h
--- a/drivers/net/ethernet/freescale/ucc_geth.h 2014-10-22
15:19:16.000000000 +0300
+++ b/drivers/net/ethernet/freescale/ucc_geth.h 2014-10-22
15:24:39.000000000 +0300
@@ -541,6 +541,8 @@
replaced */
u32 insertvlan; /* total frames that had their VLAN tag
inserted */
+ u32 checksumerr; /* total frames that have IP Checksum Error
+ */
} __packed;

struct ucc_geth_rx_interrupt_coalescing_entry {



Best Regards,
Ioannis

Attachment: smime.p7s
Description: S/MIME cryptographic signature