Re: [PATCH] usb: serial: Fix indentation style issue

[Johan Hovold]

On Wed, Oct 22, 2014 at 04:40:24PM +0200, Philip Munksgaard wrote:
> On 22 October 2014 16:18, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> >> On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> >> > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> >> > > Fix a style issue
> >> > >
> >> > > Signed-off-by: Philip Munksgaard <pmunksgaard@xxxxxxxxx>
> >> > > ---
> >> > >  drivers/usb/serial/option.c | 2 +-
> >> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> > >
> >> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> >> > > index d1a3f60..d88998d 100644
> >> > > --- a/drivers/usb/serial/option.c
> >> > > +++ b/drivers/usb/serial/option.c
> >> > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> >> > >   { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> >> > >   { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> >> > >             .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> >> > > -         },
> >> > > + },
> >> >
> >> > Why not fix the same 'space' issue on the line before this at the same
> >> > time?
> >>
> >> And what about the remaining white-space issues in this file? Do we
> >> really want to go down this path?
> >
> > No, we don't, if you want to have patches be able to apply properly to
> > older kernels, as you point out.
> >
> > Just don't add new whitespace issues please, that's all.
>
> I'm a bit confused. I've already submitted a new patch that merges the
> two lines and fixes the whitespace issues on both (if you can't find
> it, let me know and I'll resend it), is there anything else I'm
> supposed to do?

No, we're just not going to apply such fix-white-space patches, sorry.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/