Re: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver

[Peter Zijlstra]

On Mon, Oct 13, 2014 at 04:45:40PM +0300, Alexander Shishkin wrote:
> +static int pt_config(struct perf_event *event)
> +{
> +	u64 reg;
> +
> +	reg = RTIT_CTL_TOPA | RTIT_CTL_BRANCH_EN;
> +
> +	if (!event->attr.exclude_kernel)
> +		reg |= RTIT_CTL_OS;
> +	if (!event->attr.exclude_user)
> +		reg |= RTIT_CTL_USR;
> +
> +	reg |= (event->attr.config & PT_CONFIG_MASK);
> +
> +	/*
> +	 * User can try to set bits in RTIT_CTL through PT_BYPASS_MASK,
> +	 * that aren't supported by the hardware. Weather or not a
> +	 * particular bitmask is supported by a cpu can't be determined
> +	 * via cpuid or otherwise, so we have to rely on #GP handling
> +	 * to catch these cases.
> +	 */
> +	return wrmsrl_safe(MSR_IA32_RTIT_CTL, reg);
> +}

Whether the weather is nice or not :-)

But no, this cannot be, once we've accepted the event is must be
programmable. Failing at the time of programming is vile; pmu::start()
is a void return, failure is not an option there.

The fact that the hardware cannot even tell you the supported mask is
further fail.

IIRC I think Andi once suggested probing each of the 64 bits in that MSR
to determine the supported mask at device init time.

BTW, what's that RTIT thing? Did someone forget to propagate the latest
name change of the thing or so?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/