Re: [PATCH v2] drivers: net: xgene: Rewrite loop in xgene_enet_ecc_init()

[David Miller]

From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Wed, 22 Oct 2014 09:39:41 +0200

> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ʽxgene_enet_ecc_initʼ:
> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ʽdataʼ may be used uninitialized in this function
> 
> Depending on the arbitrary value on the stack, the loop may terminate
> too early, and cause a bogus -ENODEV failure.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> v2: Rewrite the loop instead of pre-initializing data.

I hate to be a pest, but like the other patch of your's I think
a do { } while() works best here because the intent is clearly
to run the loop at least once, right?