Re: [PATCH v2 2/2] arm: pm: add deep sleep support for LS1

From: Arnd Bergmann
Date: Thu Oct 23 2014 - 03:52:29 EST


On Thursday 23 October 2014 12:16:13 Chenhui Zhao wrote:
> +extern void ls1_do_deepsleep(unsigned long addr);
> +extern void ls1_start_fsm(void);
> +extern void ls1_deepsleep_resume(void);
> +extern void ls1021a_set_secondary_entry(void);
> +extern int ls1_sram_code_size;
> +extern void fsl_epu_setup_default(void __iomem *epu_base);
> +

Please move these into a header file out of principle. I realize they
are defined in an assembly file, so the change won't actually add
any type safety as it would for functions defined in C files, but it's
better to be consistent.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/