Re: [PATCH v3 4/5] regulator: max77802: Parse regulator operating mode properties

[Javier Martinez Canillas]

Hello Mark,

> On 22/10/2014, at 18:48, Mark Brown <broonie@xxxxxxxxxx> wrote:
> 
>> On Mon, Oct 20, 2014 at 04:47:51PM +0200, Javier Martinez Canillas wrote:
>> 
>> +    char *states[PM_SUSPEND_MAX + 1] = {
>> +        [PM_SUSPEND_MEM] = "regulator-state-mem",
>> +        [PM_SUSPEND_MAX] = "regulator-state-disk",
>> +    };
> 
> This still has the same problem as your previous patch with things not
> being as joined up with the core as they should be.  What I'd like to
> see is that the code to extract the number for each state is in the core
> and then the drivers just provide a translation function to map from
> this to the internal modes.

Ok, I'll send a new version parsing it in the core and providing a translation function in the driver as you said.

However this is an implementation detail and should not change the DT bindings in the current version. Could you please let me know if you have any issues with the other patches from this series so I can address all of them when doing a re-spin?

Thanks a lot and best regards,
Javier--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/