[GIT PULL] Remove weak function declarations
From: Bjorn Helgaas
Date: Thu Oct 23 2014 - 13:14:54 EST
Hi Linus,
Here are some changes to fix possible issues with "weak" functions.
They're not PCI-related; I just put them in my tree to get them into
linux-next for a few days.
I don't have any problem reports for these, so they're just potential
issues at this point, but I think it's worth including these changes in
v3.18 because the current behavior is so counter-intuitive.
Bjorn
The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/remove-weak-declarations
for you to fetch changes up to 271a9c35158910496f6fc3a635c2ed85df6be3d9:
uprobes: Remove "weak" from function declarations (2014-10-22 16:14:04 -0600)
----------------------------------------------------------------
The "weak" attribute is commonly used for the default version of a
function, where an architecture can override it by providing a strong
version.
Some header file declarations included the "weak" attribute. That's
error-prone because it causes every implementation to be weak, with no
strong version at all, and the linker chooses one based on link order.
What we want is the "weak" attribute only on the *definition* of the
default implementation. These changes remove "weak" from the declarations,
leaving it on the default definitions.
----------------------------------------------------------------
Bjorn Helgaas (7):
audit: Remove "weak" from audit_classify_compat_syscall() declaration
x86, intel-mid: Remove "weak" from function declarations
clocksource: Remove "weak" from clocksource_default_clock() declaration
vmcore: Remove "weak" from function declarations
kgdb: Remove "weak" from kgdb_arch_pc() declaration
memory-hotplug: Remove "weak" from memory_block_size_bytes() declaration
uprobes: Remove "weak" from function declarations
Vineet Gupta (1):
ARC: kgdb: generic kgdb_arch_pc() suffices
arch/arc/kernel/kgdb.c | 5 -----
arch/x86/platform/intel-mid/intel_mid_weak_decls.h | 7 +++----
include/linux/audit.h | 2 +-
include/linux/clocksource.h | 2 +-
include/linux/crash_dump.h | 15 +++++++--------
include/linux/kgdb.h | 2 +-
include/linux/memory.h | 2 +-
include/linux/uprobes.h | 14 +++++++-------
8 files changed, 21 insertions(+), 28 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/