Re: [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4)

[Namhyung Kim]

On Thu, 23 Oct 2014 20:35:42 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 22, 2014 at 10:34:27AM +0900, Namhyung Kim escreveu:
>> Hi Arnaldo,
>> 
>> On Wed, 15 Oct 2014 17:06:30 -0300, Arnaldo Carvalho de Melo wrote:
>> > Next time please run: (I'm fixing this up this time)
>> >
>> > [acme@zoo linux]$ time make -C tools/perf build-test
>> ...
>> > In file included from util/machine.c:14:0:
>> > util/unwind.h: In function âunwind__prepare_accessâ:
>> > util/unwind.h:47:57: error: unused parameter âthreadâ
>> > [-Werror=unused-parameter]
>> >  static inline int unwind__prepare_access(struct thread *thread)
>> >                                                          ^
>> > util/unwind.h: In function âunwind__finish_accessâ:
>> > util/unwind.h:52:57: error: unused parameter âthreadâ
>> > [-Werror=unused-parameter]
>> >  static inline void unwind__finish_access(struct thread *thread) {}
>> >                                                          ^
>> > cc1: all warnings being treated as errors
>> > make[3]: *** [util/machine.o] Error 1
>> > make[3]: *** Waiting for unfinished jobs....
>> > make[2]: *** [all] Error 2
>> >   test: test -x ./perf
>> > make[1]: *** [make_no_libelf] Error 1
>> > make: *** [build-test] Error 2
>> > make: Leaving directory `/home/git/linux/tools/perf'
>> 
>> So it seems you didn't include the patch 3/5 which is the key of this
>> series..  Could you please check it again?
>
> Yeah, I'm adding it now, and in this case as well the __maybe_unused was
> missing, added.

It was my bad to miss the annotation, sorry.


>
> I'll push later and will drop you a note, so that you can, please, check
> if the end result is sane.

Thank you!

> Sorry for the slip up,

No problem. :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/