Re: [PATCH v4 4/6] ARM: rockchip: add suspend and resume for RK3288

[Doug Anderson]

Chris,

On Tue, Oct 21, 2014 at 4:25 PM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> +static inline void rk3288_copy_data_to_sram(void)
> +{
> +       u32 resume_code_size = (u32)&rkpm_bootdata_cpu_code -
> +                              (u32)rockchip_slp_cpu_resume + 4;
> +
> +       /* save root sram data in ddr mem */
> +       memcpy(rk3288_bootram_base, bootram_save_data, SZ_4K);

I swore we looked at this before, but the above memcpy is backwards.

> +       /* move resume code and data to bootsram */
> +       memcpy(rk3288_bootram_base, rockchip_slp_cpu_resume,
> +              resume_code_size);
> +}
> +
> +static inline void rk3288_restore_original_sram(void)
> +{
> +       memcpy(bootram_save_data, rk3288_bootram_base, SZ_4K);

This one too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/