Re: [PATCH net] bpf: split eBPF out of NET

[Geert Uytterhoeven]

On Fri, Oct 24, 2014 at 10:11 AM, Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
>> >> +config BPF_SYSCALL
>> >> +     bool "Enable bpf() system call" if EXPERT
>> >> +     select ANON_INODES
>> >> +     select BPF
>> >> +     default n
>> >> +     help
>> >> +       Enable the bpf() system call that allows to manipulate eBPF
>> >> +       programs and maps via file descriptors.
>> >
>> > Not sure this one goes under EXPERT, especially since it currently has
>> > "default n".
>>
>> I followed the same style as EPOLL, EVENTFD and others
>> in the same category.
>
> I was thinking of CROSS_MEMORY_ATTACH and FHANDLE in the same file.

Those indeed look like better examples.
With if EXPERT and default n, you need to enable EXPERT before you can
enable the syscall, which is probably not what you want.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/