Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal

[Andy Whitcroft]

On Fri, Oct 24, 2014 at 02:31:50AM -0700, Joe Perches wrote:
> On Fri, 2014-10-24 at 10:02 +0100, Andy Whitcroft wrote:
> > On Thu, Oct 23, 2014 at 10:29:11AM -0700, Joe Perches wrote:
> > 
> > [...]
> > >  my $P = $0;
> > > -$P =~ s@(.*)/@@g;
> > > -my $D = $1;
> > > +my $D = dirname(abs_path($P));
> > 
> > That changes the value of $P, I don't know if that is intended:
> > 
> >   my $D = dirname(abs_path($0));
> > 
> > or
> > 
> >   my $D = abs_path($1);
> > 
> > perhaps to keep $P as it was.
> 
> I did it to show the executable passed on the cmdline better.
> 
> It changes --help and some warn/die messages.
> 
> It's not particularly important either way.

If it was intended then great.  Either way is fine with me.

Acked-by: Andy Whitcroft <apw@xxxxxxxxxxxxx>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/