Re: [PATCH v2 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc

[Haojian Zhuang]

On Thu, Oct 23, 2014 at 10:04 PM, Zhou Wang <wangzhou.bry@xxxxxxxxx> wrote:
> Signed-off-by: Zhou Wang <wangzhou.bry@xxxxxxxxx>
> ---
>  drivers/mtd/nand/Kconfig        |    5 +
>  drivers/mtd/nand/Makefile       |    1 +
>  drivers/mtd/nand/hisi504_nand.c |  836 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 842 insertions(+)
>  create mode 100644 drivers/mtd/nand/hisi504_nand.c
>

I think that you need to run scripts/checkpatch.pl. There're some
warnings reported on this patch.

> +
> +       case NAND_CMD_SEQIN:
> +               host->offset = column;
> +

It's better not using waterfall style. Maybe you can write it clearly.
            case NAND_CMD_SEQIN:
                    host->offset = column;
                    set_addr(mtd, column, page_addr);
                    break;

> +       chip->ecc.mode = of_get_nand_ecc_mode(np);
> +       /* read ecc-bits from dts */
> +       of_property_read_u32(np, "hisi,nand-ecc-bits", &host->ecc_bits);

Do you need to check the ecc_bits at here? Maybe user inputed the
wrong ecc_bits in DTS.

Best Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/