Re: [PATCH 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

[Daniel Lezcano]

On 10/24/2014 03:38 PM, Peter Zijlstra wrote:
> On Mon, Oct 20, 2014 at 06:25:41PM +0200, Daniel Lezcano wrote:
> > +++ b/kernel/sched/idle.c
> > @@ -162,7 +162,8 @@ use_default:
> >   	/*
> >   	 * Give the governor an opportunity to reflect on the outcome
> >   	 */
> > -	cpuidle_reflect(dev, entered_state);
> > +	if (entered_state >= 0)
> > +		cpuidle_reflect(dev, entered_state);
>
> Given we'll do use_default: when next_state < 0, we actually never get
> here unless this is true.

There is the 'cpuidle_enter' call in between which may fail.



--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/