Re: [PATCH 2/2] zram: avoid NULL pointer access when reading mem_used_total

From: Minchan Kim
Date: Sat Oct 25 2014 - 21:45:05 EST


On Sat, Oct 25, 2014 at 05:26:31PM +0800, Weijie Yang wrote:
> There is a rare NULL pointer bug in mem_used_total_show() in concurrent
> situation, like this:
> zram is not initialized, process A is a mem_used_total reader which runs
> periodicity, while process B try to init zram.
>
> process A process B
> access meta, get a NULL value
> init zram, done
> init_done() is true
> access meta->mem_pool, get a NULL pointer BUG
>
> This patch fixes this issue.
>
> Signed-off-by: Weijie Yang <weijie.yang@xxxxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Thanks!

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/