Re: [PATCH v2 2/3] ARM: dts: socfpga: fpga bridges bindings docs

[Pantelis Antoniou]

Hi Mark,

> On Oct 27, 2014, at 17:01 , Mark Brown <broonie@xxxxxxxxxx> wrote:
> 
> On Mon, Oct 27, 2014 at 01:48:02PM +0200, Pantelis Antoniou wrote:
>>> On Oct 24, 2014, at 02:51 , atull@xxxxxxxxxxxxxxxxxxxxx wrote:
> 
>>> + - init-val         : 0 if driver should disable bridge at startup
>>> +                      1 if driver should enable bridge at startup
>>> +                      driver leaves bridge in current state if property not
>>> +		      specified.
> 
>> Isnât init-val a boolean property? Itâs not named very well.
> 
> It's not boolean, it's tristate - turn on, turn off or don't touch.
> 

I see. Even then âinit-valâ is cryptic. Iâd prefer two booleans,
enable-at-startup; disable-at-startup.

>> Along with the label, is kinda hard to defend as configuration in DT.
> 
> Yeah...  presumably this decision would fall out of the users?

Well, itâs the user that should make the decision, but the driver should
pick it up. This works but itâs not very nice.

Regards

â Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/