Re: [PATCH v2 12/47] mfd: ab8500-sysctrl: Register with kernel poweroff handler

[Guenter Roeck]

On Mon, Oct 27, 2014 at 04:59:00PM +0100, Linus Walleij wrote:
> On Tue, Oct 21, 2014 at 6:12 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> 
> > Register with kernel poweroff handler instead of setting pm_power_off
> > directly. Register with low priority to reflect that the original code
> > only sets pm_power_off if it was not already set.
> >
> > sysctrl_dev is set prior to poweroff handler registration, and the
> > poweroff handler is unregistered prior to clearing sysrctrl_dev.
> > It is therefore not necessary to check if sysctrl_dev is NULL in the
> > poweroff handler, and the check was removed. Setting sysctrl_dev to NULL
> > in the remove function was also removed as unnecessary. With those changes,
> > devm_register_power_off_handler can be used to register the poeroff handler.
> > The now empty remove function was retained since the ab8500_restart function,
> > which is currently unused, would likely need some cleanup if it was ever used.
> >
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > v2:
> > - Use define to specify poweroff handler priority
> > - Use devm_register_power_off_handler
> > - Use dev_warn instead of dev_err
> > - Since we use devm_register_power_off_handler,
> >   we need to check if sysctrl_dev in the poweroff handler to avoid
> >   a race condition on unload, so this check is no longer removed
> 
> I can't compile this, I guess because of a dependency on some
> other patch?
> 
Hi Linus,

can you try v3 ? It has a number of improvements, and POWEROFF_PRIORITY_LOW
was replaced with POWER_OFF_PRIORITY_LOW. You will need patch 01/47 of the
series as well to get the definition.

>   CC      drivers/mfd/ab8500-sysctrl.o
> ../drivers/mfd/ab8500-sysctrl.c:94:14: error: âPOWEROFF_PRIORITY_LOWâ
> undeclared here (not in a function)
>   .priority = POWEROFF_PRIORITY_LOW,
>               ^
> ../drivers/mfd/ab8500-sysctrl.c: In function âab8500_sysctrl_probeâ:
> ../drivers/mfd/ab8500-sysctrl.c:206:2: error: implicit declaration of
> function âdevm_register_power_off_handlerâ
> [-Werror=implicit-function-declaration]
>   err = devm_register_power_off_handler(sysctrl_dev, &ab8500_poweroff_nb);
> 
> I wanted to provide a Tested-by but I guess I can only give this:
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
Thanks!
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/