Re: [PATCH v2] gpio: lib-sysfs: Add 'wakeup' attribute

[Linus Walleij]

On Tue, Oct 14, 2014 at 1:50 AM, Soren Brinkmann
<soren.brinkmann@xxxxxxxxxx> wrote:

> Add an attribute 'wakeup' to the GPIO sysfs interface which allows
> marking/unmarking a GPIO as wake IRQ.
> The file 'wakeup' is created in each exported GPIOs directory, if an IRQ
> is associated with that GPIO and the irqchip implements set_wake().
> Writing 'enabled' to that file will enable wake for that GPIO, while
> writing 'disabled' will disable wake.
> Reading that file will return either 'disabled' or 'enabled' depening on
> the currently set flag for the GPIO's IRQ.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
> Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
> v2:
>  - fix error path to unlock mutex before return

As you're adding an ABI, you should be patching
Documentation/ABI/testing/sysfs-gpio and
Documentation/gpio/sysfs.txt in this patch.

While I *HATE* the idea of adding IRQ support to userspace
for GPIOs, this "just" adds the wakeup capacity, so I guess I'm
OK with it.

Provided you add it to the ABI doc...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/