Re: [PATCH] arm64: amd-seattle: Adding device tree for AMD Seattle platform

From: Suravee Suthikulanit
Date: Mon Oct 27 2014 - 14:34:53 EST


On 10/27/2014 8:50 AM, Mark Rutland wrote:
Hi Suravee,

[...]

+ chosen {
+ linux,stdout-path = "console=ttyAMA0,115200 earlycon=pl011,0xe1010000";

The stdout-path property should just be a path to the UART node. It's
not a direct replacement for /chosen/bootargs.

This should be (assuming you fix up the label above):

stdout-path = &serial0;

That will give us earlycon if "earlycon" (with no arguments) is provided
on the command line, and should set up that UART as the console. There's
no need for the "linux," prefix now either.

Unfortuantely, I believe that the UART rate will get changed when the
real PL011 driver registers, unless the rate is explicitly provided on
the command line. It might be worth looking into retaining the
configured rate somehow indepentent of bootargs (unless overriden).

Thanks for the explanation. I think I should be able to get rid of the "console=ttyAMA0,115200 earlycon=pl011,0xe1010000" altogether. I'll send out V2 soon.

Thanks,

Suravee

Thanks,
Mark.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/