Re: [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle platform

From: Suravee Suthikulanit
Date: Mon Oct 27 2014 - 15:15:12 EST


On 10/27/2014 2:07 PM, Arnd Bergmann wrote:
On Monday 27 October 2014 13:54:25 suravee.suthikulpanit@xxxxxxx wrote:
+ sata0: sata@00300000 {
+ compatible = "snps,spear-ahci";
+ reg = <0 0x300000 0 0x800>;
+ interrupts = <0 355 4>;
+ clocks = <&sataclk_333mhz>;
+ clock-names = "apb_pclk";
+ dma-coherent;
+ };

Please use "snps,dwc-ahci" as the compatible string for a designware
ahci controller, not "snps,spear-ahci", which refers to the implementation
of that in the ST microelectronics SPEAr consumer SoC.

It would be good to also add a string that is specific for your SoC if
we ever need to identify it directly.

Arnd


Thanks. I will update this in V3.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/