Re: [PATCH] net: ethernet: realtek: atp: checkpatch errors and warnings corrected

[Roberto Medina]

On 10/27/2014 11:53 PM, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Mon, 27 Oct 2014 18:52:11 -0400 (EDT)
>
> > From: Roberto Medina <robertoxmed@xxxxxxxxx>
> > Date: Thu, 23 Oct 2014 19:10:00 +0200
> >
> > > From: Roberto Medina <robertoxmed@xxxxxxxxx>
> > >
> > > Several warnings and errors of coding style errors corrected.
> > >
> > > Signed-off-by: Roberto Medina <robertoxmed@xxxxxxxxx>
> >
> > Applied, thanks.
>
> Wait, are you serious, you didn't even compile test this change?
>
> For real?
>
> In file included from drivers/net/ethernet/realtek/atp.c:146:0:
> drivers/net/ethernet/realtek/atp.h:79:15: error: expected ʽ;ʼ, identifier or ʽ(ʼ before ʽunsignedʼ
>   static inline unsigned char inbyte(unsigned short port)
>                 ^
> drivers/net/ethernet/realtek/atp.h:79:15: error: ʽinlineʼ in empty declaration

Wow I'm really sorry for that, I did compile my changes, or at least 
that's what I thought when I compiled the directory.

Will submit another patch. Sorry for the inconvenience again.

> Don't even submit changes meant for inclusion if you're not even
> willing to build test them.
>
> And I'm very serious about this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/