Re: [PATCH v14 2/5] dt-bindings: document Rockchip thermal

[Caesar Wang]

Dmitry,

å 2014å10æ28æ 08:29, Dmitry Torokhov åé:
> On Mon, Oct 27, 2014 at 10:39:45AM +0800, Caesar Wang wrote:
> > This add the necessary binding documentation for the thermal
> > found on Rockchip SoCs
> >
> > Signed-off-by: zhaoyifeng <zyf@xxxxxxxxxxxxxx>
> > Signed-off-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx>
> > ---
> >   .../bindings/thermal/rockchip-thermal.txt          | 53 ++++++++++++++++++++++
> >   1 file changed, 53 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > new file mode 100644
> > index 0000000..d5b1401
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > @@ -0,0 +1,53 @@
> > +* Temperature Sensor ADC (TSADC) on rockchip SoCs
> > +
> > +Required properties:
> > +- compatible : "rockchip,rk3288-tsadc"
> > +- reg : physical base address of the controller and length of memory mapped
> > +	region.
> > +- interrupts : The interrupt number to the cpu. The interrupt specifier format
> > +	       depends on the interrupt controller.
> > +- clocks : Must contain an entry for each entry in clock-names.
> > +- clock-names : Shall be "tsadc" for the converter-clock, and "apb_pclk" for
> > +		the peripheral clock.
> > +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> I think you are missing description of hw-shut-temp, tsadc-tshut-mode
> and tsadc-tshut-mode
>   and optional pinctrl settings.

If it's really need,we just have hw-shut-temp,tsadc-tshut-mode
and tsadc-tshut-mode,no need  pinctrl setting,I think.

> > +
> > +Exiample:
> > +tsadc: tsadc@ff280000 {
> > +	compatible = "rockchip,rk3288-tsadc";
> > +	reg = <0xff280000 0x100>;
> > +	interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> > +	clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>;
> > +	clock-names = "tsadc", "apb_pclk";
> > +};
> > +
> > +Example: referring to thermal sensors:
> > +thermal-zones {
> > +	cpu_thermal: cpu_thermal {
> > +		polling-delay-passive = <1000>; /* milliseconds */
> > +		polling-delay = <5000>; /* milliseconds */
> > +
> > +		/* sensor	ID */
> > +		thermal-sensors = <&tsadc	1>;
> > +
> > +		trips {
> > +			cpu_alert0: cpu_alert {
> > +				temperature = <80000>; /* millicelsius */
> > +				hysteresis = <2000>; /* millicelsius */
> > +				type = "passive";
> > +			};
> > +			cpu_crit: cpu_crit {
> > +				temperature = <120000>; /* millicelsius */
> > +				hysteresis = <2000>; /* millicelsius */
> > +				type = "critical";
> > +			};
> > +		};
> > +
> > +		cooling-maps {
> > +			map0 {
> > +				trip = <&cpu_alert0>;
> > +				cooling-device =
> > +					<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +			};
> > +		};
> > +	};
> > +};
> > --
> > 1.9.1

--
Best regards,
Caesar


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/