Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore

[Peter Zijlstra]

On Tue, Oct 28, 2014 at 04:19:21AM -0700, Andi Kleen wrote:
> > +config PERF_EVENTS_INTEL_UNCORE
> > +	def_bool y
> 
> Why not give it a user name? It should be user configurable.

To avoid just that, another more or less pointless config option.

> > +	depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
> 
> SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
> 
> I suspect you disabled it completely.

Indeed, typo there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/