Re: [PATCH v2] ssb: Fix Sparse error in main

[Michael BÃsch]

On Tue, 28 Oct 2014 22:03:02 +0530
Pramod Gurav <pramod.gurav.etc@xxxxxxxxx> wrote:

> Michael had suggested to do away with this function if not being used.
> Good to go?
> 
> Michale can you provide acked-by?

Yes, this looks good.
Acked-by: Michael BÃsch <m@xxxxxxx>

> On Wed, Oct 1, 2014 at 10:58 PM, Pramod Gurav
> <pramod.gurav@xxxxxxxxxxxxxxx> wrote:
> > This change fixes below sparse error:
> > drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
> > was not declared. Should it be static?
> >
> > Cc: Michael Buesch <m@xxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Signed-off-by: Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx>
> > ---
> > Changes since v1:
> > Removed the function as it is not called anywhere in the kernel
> > as per suggestion from Michael Buesch.
> >
> >  drivers/ssb/main.c | 19 -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> > index 2fead38..1e180c4 100644
> > --- a/drivers/ssb/main.c
> > +++ b/drivers/ssb/main.c
> > @@ -90,25 +90,6 @@ found:
> >  }
> >  #endif /* CONFIG_SSB_PCMCIAHOST */
> >
> > -#ifdef CONFIG_SSB_SDIOHOST
> > -struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func)
> > -{
> > -       struct ssb_bus *bus;
> > -
> > -       ssb_buses_lock();
> > -       list_for_each_entry(bus, &buses, list) {
> > -               if (bus->bustype == SSB_BUSTYPE_SDIO &&
> > -                   bus->host_sdio == func)
> > -                       goto found;
> > -       }
> > -       bus = NULL;
> > -found:
> > -       ssb_buses_unlock();
> > -
> > -       return bus;
> > -}
> > -#endif /* CONFIG_SSB_SDIOHOST */
> > -
> >  int ssb_for_each_bus_call(unsigned long data,
> >                           int (*func)(struct ssb_bus *bus, unsigned long data))
> >  {

-- 
Michael

Attachment: pgpi43j3Hc53U.pgp
Description: OpenPGP digital signature