Re: [PATCH tip/core/rcu 4/7] rcu: Unify boost and kthread priorities

From: Peter Zijlstra
Date: Wed Oct 29 2014 - 07:02:14 EST


On Tue, Oct 28, 2014 at 03:22:59PM -0700, Paul E. McKenney wrote:
> From: Clark Williams <clark.williams@xxxxxxxxx>
>
> Rename CONFIG_RCU_BOOST_PRIO to CONFIG_RCU_KTHREAD_PRIO and use this
> value for both the per-CPU kthreads (rcuc/N) and the rcu boosting
> threads (rcub/n).
>
> Also, create the module_parameter rcutree.kthread_prio to be used on
> the kernel command line at boot to set a new value (rcutree.kthread_prio=N).
>
> Signed-off-by: Clark Williams <clark.williams@xxxxxxxxx>
> [ paulmck: Ported to rcu/dev, applied Paul Bolle feedback. ]
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
> Documentation/kernel-parameters.txt | 6 ++++++
> init/Kconfig | 23 +++++++++++-----------
> kernel/rcu/tree_plugin.h | 20 +++++++++----------
> .../selftests/rcutorture/configs/rcu/TREE03 | 2 +-
> .../selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 4 ++--
> 5 files changed, 31 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 7dbe5ec9d9cd..7d3b3328bf5c 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -2922,6 +2922,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
> quiescent states. Units are jiffies, minimum
> value is one, and maximum value is HZ.
>
> + rcutree.kthread_prio= [KNL,BOOT]
> + Set the SCHED_FIFO priority of the RCU
> + per-CPU kthreads (rcuc/N). This value is also
> + used for the priority of the RCU boost threads
> + (rcub/N). Valid values are 1-99.
> +

It would maybe be useful to mention the default?

Also, should we look at running this stuff as deadline in order to
provide interference guarantees etc.. ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/