Re: [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

[Mark Brown]

On Wed, Oct 29, 2014 at 05:23:15PM +0300, Max Filippov wrote:
> On Tue, Oct 28, 2014 at 8:38 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Tue, Oct 28, 2014 at 08:00:45PM +0300, Max Filippov wrote:

> >> > It's also about ensuring that the code is cleanly split up so that
> >> > someone can actually go in and add the required support later (and TBH

> >> Can you point me to an example of such split, so that I don't write it in
> >> an unusual way?

> > Essentially all drivers are split this way...

> But all of them have DMA registers and I2S registers completely separated,
> right? How do I share registers between pcm and i2s parts?

Just keep the code physically separate so the DMA bits are hanging off
the DMA operations and the interface setup bits are hanging off the DAI
operations rather than all mixed in together.

Attachment: signature.asc
Description: Digital signature