Re: [PATCH v4 04/14] perf tools: Add kbuild support into Makefile.kbuild

[Alexis Berlemont]

Jiri Olsa wrote:
> On Sun, Oct 26, 2014 at 12:20:29AM +0200, Alexis Berlemont wrote:
> > From: Jiri Olsa <jolsa@xxxxxxxxxx>
> 
> SNIP
> 
> > ---
> >  tools/perf/Kbuild                                  |  47 +++
> >  tools/perf/Kconfig                                 | 284 ++++++++++++++
> >  tools/perf/Makefile.kbuild                         | 431 +++++++++++++++++++++
> >  tools/perf/Makefile.perf                           |   2 +-
> >  tools/perf/arch/Kbuild                             |   3 +
> >  tools/perf/arch/arm/Kbuild                         |   2 +
> >  tools/perf/arch/arm/Makefile                       |  14 -
> >  tools/perf/arch/arm/tests/Kbuild                   |   2 +
> >  tools/perf/arch/arm/util/Kbuild                    |   3 +
> >  tools/perf/arch/arm64/Kbuild                       |   1 +
> >  tools/perf/arch/arm64/Makefile                     |   7 -
> >  tools/perf/arch/arm64/util/Kbuild                  |   2 +
> >  tools/perf/arch/powerpc/Kbuild                     |   1 +
> >  tools/perf/arch/powerpc/Makefile                   |   6 -
> >  tools/perf/arch/powerpc/util/Kbuild                |   3 +
> >  tools/perf/arch/s390/Kbuild                        |   1 +
> >  tools/perf/arch/s390/Makefile                      |   7 -
> >  tools/perf/arch/s390/util/Kbuild                   |   2 +
> >  tools/perf/arch/sh/Kbuild                          |   1 +
> >  tools/perf/arch/sh/Makefile                        |   4 -
> >  tools/perf/arch/sh/util/Kbuild                     |   1 +
> >  tools/perf/arch/sparc/Kbuild                       |   1 +
> >  tools/perf/arch/sparc/Makefile                     |   4 -
> >  tools/perf/arch/sparc/util/Kbuild                  |   1 +
> >  tools/perf/arch/x86/Kbuild                         |   1 +
> >  tools/perf/arch/x86/tests/Kbuild                   |   3 +
> >  tools/perf/{ => arch/x86}/tests/perf-time-to-tsc.c |   0
> >  tools/perf/arch/x86/util/Kbuild                    |   5 +
> >  tools/perf/bench/Kbuild                            |  12 +
> >  tools/perf/builtin-cmds.h                          |   4 +
> >  tools/perf/config/Makefile                         |  55 ++-
> >  tools/perf/config/Makefile.fix-config              | 104 +++++
> >  tools/perf/config/Makefile.fix-legacy              |  46 +++
> >  tools/perf/config/defconfig                        |  54 +++
> >  tools/perf/perf-sys.h                              |   4 +-
> >  tools/perf/scripts/perl/Perf-Trace-Util/Kbuild     |   6 +
> >  tools/perf/scripts/python/Perf-Trace-Util/Kbuild   |   5 +
> >  tools/perf/tests/Kbuild                            |  38 ++
> >  tools/perf/ui/Kbuild                               |  15 +
> >  tools/perf/ui/browsers/Kbuild                      |   9 +
> >  tools/perf/ui/gtk/Kbuild                           |   9 +
> >  tools/perf/ui/stdio/Kbuild                         |   1 +
> >  tools/perf/ui/tui/Kbuild                           |   4 +
> >  tools/perf/util/Kbuild                             | 126 ++++++
> >  tools/perf/util/PERF-VERSION-GEN                   |   4 +
> >  tools/perf/util/generate-cmdlist.sh                |   8 +-
> >  tools/perf/util/scripting-engines/Kbuild           |  11 +
> >  tools/perf/util/setup.py                           |   8 +-
> 
> so this patch took the perf Makefile (at that time) and changed it to
> use the kbuild.. but since that time the Makefile.perf came and many
> other changes, which need to be reflected in Makefile.kbuild
> 
> I need to revisit the logic and split the change into more incremental
> patches (the patchset is too big)
> 
> I can redo patches 2,3,4 and get back to you, sounds ok?

Of course. 

Which changes in Makefile.perf do you have in mind ? I thought that
Makefile.kbuild was just supposed to build the few extra dependencies
(libtraceevent, etc.). I thought that I updated your original patch
accordingly with the changes before and after the add of
Makefile.perf.

Alexis.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/