Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors

[Arnd Bergmann]

On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote:
> Defining these macros way down in arch/sh/.../irq.c doesn't cause
> kernel/irq/generic-chip.c to use them.  As far as I can tell this code
> has no effect.
> 
> Signed-off-by: Kevin Cernekee <cernekee@xxxxxxxxx>

Actually it overrides the 32-bit accessors with 16-bit accessors,
which does seem intentional and certainly has an effect.

	Arnd

>  arch/sh/boards/mach-se/7343/irq.c | 3 ---
>  arch/sh/boards/mach-se/7722/irq.c | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/arch/sh/boards/mach-se/7343/irq.c b/arch/sh/boards/mach-se/7343/irq.c
> index 7646bf0..1087dba 100644
> --- a/arch/sh/boards/mach-se/7343/irq.c
> +++ b/arch/sh/boards/mach-se/7343/irq.c
> @@ -14,9 +14,6 @@
>  #define DRV_NAME "SE7343-FPGA"
>  #define pr_fmt(fmt) DRV_NAME ": " fmt
>  
> -#define irq_reg_readl  ioread16
> -#define irq_reg_writel iowrite16
> -
>  #include <linux/init.h>
>  #include <linux/irq.h>
>  #include <linux/interrupt.h>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/