Re: [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range

From: Russell King - ARM Linux
Date: Thu Oct 30 2014 - 06:18:34 EST


On Thu, Oct 30, 2014 at 01:26:06AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 29, 2014 at 11:06:58PM +0100, Rabin Vincent wrote:
> > ARM has some private syscalls (for example, set_tls(2)) which lie
> > outside the range of NR_syscalls. If any of these are called while
> > syscall tracing is being performed, out-of-bounds array access will
> > occur in the ftrace and perf sys_{enter,exit} handlers.
>
> While this patch looks like good caution, having syscalls outside of
> NR_syscalls seems like a receipe for a disaster. Can you try to fix
> that issue as ell, please?

No. We've had them since the inception of Linux on ARM. They predate
this tracing crap by more than a decade. We're not changing them
because that would be a massive user API breakage.

--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/