Re: [PATCH] Add ltc3562 voltage regulator driver

From: Mark Brown
Date: Thu Oct 30 2014 - 08:05:22 EST


On Thu, Oct 30, 2014 at 12:31:42PM +0100, Mike Looijmans wrote:
> ïOn 10/30/2014 11:58 AM, Mark Brown wrote:

> >>Hmm, I looked into doing that, but that isn't trivial, and too many devices
> >>will suffer.

> >Why would this have a negative effect on other devices? Unless somehow
> >the other devices add the property they should not be affected by it; if
> >users do add the property presumably that's because it's doing something
> >useful.

> The "default" would end up in the constraints, thus adding extra fields to
> that struct.

Sure, but why is that a problem?

> So far, all other drivers have accomplished this by setting min=max, and
> some experimenting proved that my driver is no exception to that. It even
> reduced the amount of code.

Yes, if you don't need to both set an initial voltage and support
voltage changing that works - it sounded like you needed both.

Attachment: signature.asc
Description: Digital signature