Re: [PATCH 5/7] staging: comedi: don't allow write() on async command set up for "read"

[Ian Abbott]

On 30/10/14 18:07, Hartley Sweeten wrote:
> On Thursday, October 30, 2014 5:43 AM, Ian Abbott wrote:
[snip]
> >   	add_wait_queue(&async->wait_head, &wait);
> >   	on_wait_queue = true;
> > @@ -2146,6 +2150,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf,
> >   				retval = -EACCES;
> >   				break;
> >   			}
> > +			if (!(async->cmd.flags & CMDF_WRITE)) {
> > +				retval = -EINVAL;
> > +				break;
> > +			}
>
> Same question as with PATCH 4/7.
>
> Is this test needed in the while () loop. Also, are the s->busy tests needed here?

Yes, for similar reasons.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/