Re: [PATCH v16 2/5] dt-bindings: document Rockchip thermal

[Caesar Wang]

Heiko,

å 2014å10æ31æ 04:17, Heiko StÃbner åé:
> Am Mittwoch, 29. Oktober 2014, 10:32:36 schrieb Caesar Wang:
> > This add the necessary binding documentation for the thermal
> > found on Rockchip SoCs
> >
> > Signed-off-by: zhaoyifeng <zyf@xxxxxxxxxxxxxx>
> > Signed-off-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx>
> > Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > ---
> >   .../bindings/thermal/rockchip-thermal.txt          | 62
> > ++++++++++++++++++++++ 1 file changed, 62 insertions(+)
> >   create mode 100644
> > Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt new file
> > mode 100644
> > index 0000000..3061982
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > @@ -0,0 +1,62 @@
> > +* Temperature Sensor ADC (TSADC) on rockchip SoCs
> > +
> > +Required properties:
> > +- compatible : "rockchip,rk3288-tsadc"
> > +- reg : physical base address of the controller and length of memory mapped
> > +	region.
> > +- interrupts : The interrupt number to the cpu. The interrupt specifier
> > format +	       depends on the interrupt controller.
> > +- clocks : Must contain an entry for each entry in clock-names.
> > +- clock-names : Shall be "tsadc" for the converter-clock, and "apb_pclk"
> > for +		the peripheral clock.
> > +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> > +- hw-shut-temp : The hardware-controlled shutdown temperature value. +-
> > tsadc-tshut-mode : The hardware-controlled shutdown mode 0:CRU 1:GPIO. +-
> > tsadc-tshut-polarity : The hardware-controlled active polarity 0:LOW
> > 1:HIGH. +
> > +Exiample:
> > +tsadc: tsadc@ff280000 {
> > +	compatible = "rockchip,rk3288-tsadc";
> > +	reg = <0xff280000 0x100>;
> > +	interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> > +	clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>;
> > +	clock-names = "tsadc", "apb_pclk";
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&otp_out>;
> > +	#thermal-sensor-cells = <1>;
> > +	hw-shut-temp = <125000>;
> > +	tsadc-tshut-mode = <0>;
> > +	tsadc-tshut-polarity = <0>;
> these last 3 seem to be specific to this tsadc so should probably have a
> "rockchip,"-prefix

Fixed.

e.g  sync to driver

rockchip,hw-shut-temp = <125000>;
rockchip,tsadc-tshut-mode = <0>;
rockchip,tsadc-tshut-polarity = <0>;



I will sent next patch  v17 in 1-2 days if this series patchs haven't 
any problems.

Thanks.

>

--
Best regards,
Caesar


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/