Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0

[Eric Rannaud]

On Thu, Oct 30, 2014 at 6:04 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Oct 30, 2014 at 5:57 PM, Eric Rannaud <e@xxxxxxxxxxxxxxxx> wrote:
>> Yes, there definitely is a glibc bug: a fix is being worked on and it
>> looks like it will go in. The change replaces the test for O_CREAT by
>> a test for either O_CREAT or O_TMPFILE.
>
> Why not just do it unconditionally? There really is no downside. Doing
> it conditionally only makes the generated code slower and mode
> complex. For absolutely zero gain, as far as I can tell. Does any
> architecture actually do anything wrong?

The immediate answer is "to keep the diff minimal". But I'll ask.

-- 
Eric Rannaud <e@xxxxxxxxxxxxxxxx>
Nanocritical, CEO
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/