RE: [RFC] arm:remove clear_thread_flag(TIF_UPROBE)

[Wang, Yalin]

> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> > > > @@ -591,10 +591,9 @@ do_work_pending(struct pt_regs *regs, unsigned
> int
> > > thread_flags, int syscall)
> > > >  					return restart;
> > > >  				}
> > > >  				syscall = 0;
> > > > -			} else if (thread_flags & _TIF_UPROBE) {
> > > > -				clear_thread_flag(TIF_UPROBE);
> > > > +			} else if (thread_flags & _TIF_UPROBE)
> > > >  				uprobe_notify_resume(regs);
> > > > -			} else {
> > > > +			else {
> > > >  				clear_thread_flag(TIF_NOTIFY_RESUME);
> > > >  				tracehook_notify_resume(regs);
> > > >  			}
> > >
> > > Please keep the braces.
> >
> > mm..  could I know the reason ?  :)
> 
> Try read Documentation/CodingStyle
> 
> 		Chapter 3: Placing Braces and Spaces
> 
> use braces in both branches:
> 
> if (condition) {
> 	do_this();
> 	do_that();
> } else {
> 	otherwise();
> }
> 

Got it,  I will resend one .
Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/