Re: [PATCH v3 00/17] Cross-architecture definitions of relaxed MMIO accessors

From: Thierry Reding
Date: Fri Oct 31 2014 - 07:10:08 EST


On Thu, Oct 30, 2014 at 09:04:54PM +0100, Arnd Bergmann wrote:
> On Thursday 30 October 2014 16:59:07 Will Deacon wrote:
> > On Thu, Sep 25, 2014 at 02:15:10PM +0100, Arnd Bergmann wrote:
> > > On Wednesday 24 September 2014 18:17:19 Will Deacon wrote:
> > > > Hello everybody,
> > > >
> > > > This is version three of the series I've originally posted here:
> > > >
> > > > v1: https://lkml.org/lkml/2014/4/17/269
> > > > v2: https://lkml.org/lkml/2014/5/22/468
> > > >
> > > > This is basically just a rebase on top of 3.17-rc6, minus the alpha patch
> > > > (which was merged into mainline).
> > > >
> > > > I looked at reworking the non-relaxed accessors to imply mmiowb, but it
> > > > quickly got messy as some architectures (e.g. mips) deliberately keep
> > > > mmiowb and readX/writeX separate whilst others (e.g. powerpc) don't trust
> > > > drivers to get mmiowb correct, so add barriers to both. Given that
> > > > arm/arm64/x86 don't care about mmiowb, I've left that as an exercise for
> > > > an architecture that does care.
> > > >
> > > > In order to get this lot merged, we probably want to merge the asm-generic
> > > > patch (1/17) first, so Acks would be much appreciated on the architecture
> > > > bits.
> > > >
> > > > As before, I've included the original cover letter below, as that describes
> > > > what I'm trying to do in more detail.
> > > >
> > >
> > > I've now applied the parts of your series that are required to have
> > > every architecture provide all the 'relaxed' accessors to the
> > > asm-generic tree, on top of Thierry's series.
> >
> > Since these didn't make it for 3.18, would you like me to repost the series,
> > or do you already have a branch suitable for 3.19?
>
> I still need to figure out how to do this right in combination with Thierry's
> patches. Last time I had his patches first and yours on top, and I didn't
> manage to rebase your series when his broke.

Would it help if we merged both series so that we have to rebase only
once? I'd really like to get the asm-generic/io.h series merged soon
because 64-bit Tegra support depends on it and we'd really like to get
started on that.

Thierry

Attachment: pgp0cr3AfTCrt.pgp
Description: PGP signature