Re: [PATCH 0/5] staging: comedi: split bus support into separate modules

[Ian Abbott]

On 31/10/14 18:19, Hartley Sweeten wrote:
> On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
> > The Comedi core module doesn't need support for PCI, USB or PCMCIA.
> > Only the low-level Comedi drivers need it.  Split the support for these
> > bus types out of the core "comedi" module and into new modules,
> > "comedi_pci", "comedi_usb", and "comedi_pcmcia".
> >
> > 1) staging: comedi: comedidev.h: remove dummy PCI support functions
> > 2) staging: comedi: comedidev.h: remove some #ifdefs
> > 3) staging: comedi: split out PCMCIA support into new module
> > 4) staging: comedi: split out USB support into new module
> > 5) staging: comedi: split out PCI support into new module
>
> Ian,
>
> Is this really necessary?
>
> The pci, usb, and pcmcia support is already conditionally compiled in.
> The support does get added to the main comedi module instead of
> as separate modules but that shouldn't be a problem.

Well a lot of potentially unused module space could get pulled in if 
using a stock distro kernel. For example, the USB dependencies amount to 
over 200k. Not so bad for the others, especially PCI where the code is 
built in anyway.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/