Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

[Sudip Mukherjee]

On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote:
> On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote:
> > On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
> > > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
> > > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
> > > > and ft1000/ft1000-pcmcia/ft1000_hw.c:
> > > > ERROR: spaces required around that '=' (ctx:VxV)
> > > > ERROR: spaces required around that '<' (ctx:VxV)
> > > > ERROR: spaces required around that '==' (ctx:VxV)
> > > > 
> > > 
> > > many whitespace errors in the patch.
> > > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
> > 
> > When fixing one thing (like spacing), it's pretty
> > expected to have more checkpatch errors.
> > 
> > It's a process, don't worry about most intermediate
> > warnings when doing checkpatch cleanups.
> > 
> > Adding trailing spaces is not good, nearly every
> > other type of message can be ignored.
> > 
> ok, just to verify, i thought of trying to generate a similar patch which will not give checkpatch errors.
> but this patch is not applying to next-20141031.
> 
> thanks
> sudip
hi joe,
i did the similar cleanup and generated a patch, and like you said, it was giving error.
the original file has used spaces (instead of tabs) to indent the code, now to maintain similar indention
we have to introduce similar errors, or correct the indention of the full file.

looks like i have many things to learn from you, and your experience. few days back you told me about that printk thing,
now this one. thanks .. :)

sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/