Re: [PATCH] Documentation: Restrict TSC test code to x86

[Alexander Graf]

On 01.11.14 13:03, Matwey V. Kornilov wrote:
> 28.10.2014 16:12, Alexander Graf ÐÐÑÐÑ:
>>
>>
>>
>>> Am 28.10.2014 um 13:47 schrieb Jonathan Corbet <corbet@xxxxxxx>:
>>>
>>> On Mon, 27 Oct 2014 20:07:51 -0400
>>> Peter Foley <pefoley2@xxxxxxxxxxx> wrote:
>>>
>>>>> The prctl test code in Documentation/ tries to show how to
>>>>> use a call that only makes sense on x86. Restrict it there
>>>>> so that other platforms don't try to call asm("rdtsc").
>>>>>
>>>>> Signed-off-by: Alexander Graf <agraf@xxxxxxx>  
>>>>
>>>> Acked-by: Peter Foley <pefoley2@xxxxxxxxxxx>
>>>
>>> Snagged into the docs tree, thanks.
>>
>> Awesome, please make sure this makes it into 3.18 - the build is broken on non-x86 archs there ;).
>>
>> Alex
>>
> 
> Hi,
> 
> Sorry for criticism, but the patch is not complete.
> CONFIG_X86 deals with target architecture, at the same time the problem
> deals with the host architecture.
> 
> Imagine, that I run arm, aarch64 or something else and do
> cross-compiling kernel for x86 on it. Then CONFIG_X86 will evaluate to
> 'y' and make will try to compile the apps with the host-compiler, which
> is not x86 one.

Good point. Any ideas how I can easily limit this to x86 hosts?


Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/