Re: [PATCH] Documentation: Restrict TSC test code to x86

[Matwey V. Kornilov]

I've added Yann and Michal to the discussion.

The issue is that we have

hostprogs-y := disable-tsc-ctxt-sw-stress-test
disable-tsc-on-off-stress-test disable-tsc-test

in Documentation/prctl/Makefile

and disable-tsc-ctxt-sw-stress-test has x86 assembler inside and must
be restricted only to this host architecture.


2014-11-02 11:16 GMT+03:00 Alexander Graf <agraf@xxxxxxx>:
>
>
> On 02.11.14 08:46, Matwey V. Kornilov wrote:
>> I wish I knew. We need KBuild guru to ask how to take into account
>> host architecture.
>
> Hrm. At least this patch makes things more consistent with the other
> Documentation makefiles:
>
> Documentation/timers/Makefile:hostprogs-$(CONFIG_X86) := hpet_example
> Documentation/vDSO/Makefile:hostprogs-$(CONFIG_X86) :=
> vdso_standalone_test_x86
>
> But I agree, it is wrong in general - hostprogs should make sure the
> host arch matches.
>
> We could maybe just evaluate the host uname output:
>
>   ifeq ($(shell uname -m),x86_64)
>     hostprogs-$(CONFIG_X86) := ...
>   endif
>
> Then we're double safe ;). Not sure how to easily add x86 to the mix as
> well here, but I'm not sure anyone cares. Do people still compile on
> 32bit x86 hosts? And expect Documentation/ examples to build?
>
>
> Alex



-- 
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2207@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/