Re: [PATCH v2 4/6] hw_random: fix unregister race.
From: Herbert Xu
Date: Sun Nov 02 2014 - 10:08:36 EST
On Sun, Nov 02, 2014 at 11:06:13PM +0800, Amos Kong wrote:
> On Fri, Oct 31, 2014 at 03:23:21PM +0800, Herbert Xu wrote:
> > On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote:
> > > Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> writes:
> > > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote:
> > > >> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > > >>
> > > >> The previous patch added one potential problem: we can still be
> > > >> reading from a hwrng when it's unregistered. Add a wait for zero
> > > >> in the hwrng_unregister path.
> > > >>
> > > >> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > > >
> > > > You totally corrupted Rusty's patch. If you're going to repost
> > > > his series you better make sure that you've got the right patches.
> > > >
> > > > Just as well though as it made me think a little more about this
> > > > patch :)
> > >
> > > OK Amos, can you please repost the complete series?
> >
> > Please fix the unregister race I identified first.
>
> Ok, I redownload the patches from https://patchwork.kernel.org/project/LKML/list/?submitter=5
> and rebase fixes of me and rusty on it. I will post a V4 later. Thanks.
Please fix the unregister race I pointed out before doing a v4.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/