Re: [PATCH] UBI: Block: Add blk-mq support

[Ezequiel Garcia]

Hi Richard,

On 11/02/2014 10:00 AM, Richard Weinberger wrote:
> Convert the driver to blk-mq.
> 

Maybe you can explain a bit better what's this all about?

Both the commit that introduces blk-mq and the paper on it talk about
high IOPS devices, multi-core, NUMA systems. I'm not sure this is the
case for UBI-based devices.

Probably some numbers would help us decide. Does the patch increases the
dynamic memory footprint? Is there any performance benefit?

I kind of like the negative diffstat, but the code doesn't look cleaner
or simpler.

In other words, we need a good reason before we agree on making this
"zen style" driver more complex.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

Attachment: signature.asc
Description: OpenPGP digital signature