Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage

[Chris Zhong]

On 11/01/2014 04:45 PM, Javier Martinez Canillas wrote:
> Hello Doug,
>
> On 11/01/2014 04:52 AM, Doug Anderson wrote:
> > This patch builds upon (291d761 regulator: Document binding for
> > regulator suspend state for PM state) to allow setting the uV in
> > addition to the state at suspend time.
> >
> > Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> > index aaad615..4e7ed76 100644
> > --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> > @@ -28,6 +28,8 @@ Optional properties:
> >   - regulator-state-[mem/disk] node has following common properties:
> >   	- regulator-on-in-suspend: regulator should be on in suspend state.
> >   	- regulator-off-in-suspend: regulator should be off in suspend state.
> > +	- regulator-suspend-microvolt: regulator should be set to this voltage
> > +	  in suspend.
> The patch looks good to me:
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
>
> On thing I wonder is if the binding should say that the suspend voltage is
> independent of the runtime one and it may be outside of the runtime range?
>
> Best regards,
> Javier

Reviewed-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/