Re: [PATCH 3/8] perf tools: Get rid of unused dsos__hit_all()

[Adrian Hunter]

On 03/11/14 09:39, Namhyung Kim wrote:
> Hi Adrian,
> 
> On Mon, Nov 3, 2014 at 4:35 PM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>> On 03/11/14 09:27, Namhyung Kim wrote:
>>> The dsos__hit_all() and its friends are not used anywhere.  Let's get
>>> rid of them.
>>
>> They were added for Intel PT preparation.  Intel PT is still on its way,
>> so they are still needed.  Note the commit was:
>>
>> commit 1f625b0b3dd641b74ba21640a1fea19a3dd893a2
>> Author: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>> Date:   Tue Jul 22 16:17:23 2014 +0300
>>
>>     perf tools: Add dsos__hit_all()
>>
>>     Add ability to mark all dsos as hit.
>>
>>     This is needed in the case of Instruction Tracing.  It takes so long to
>>     decode an Instruction Trace that it is not worth doing just to determine
>>     which dsos are hit.  A later patch takes this into use.
> 
> Oops, didn't notice.  Sorry for not checking the commit log.  So how
> about moving it into util/build-id.c then?

OK by me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/