Re: [PATCH 2/2] blk-mq: allow direct dispatch to a driver specific workqueue

[Ming Lei]

On Mon, Nov 3, 2014 at 6:10 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Mon, Nov 03, 2014 at 04:40:47PM +0800, Ming Lei wrote:
>> The above two aren't enough because the big problem is that
>> drivers need a per-request work structure instead of 'hctx->run_work',
>> otherwise there are at most NR_CPUS concurrent submissions.
>>
>> So the per-request work structure should be exposed to blk-mq
>> too for the kind of usage, such as .blk_mq_req_work(req) callback
>> in case of BLK_MQ_F_WORKQUEUE.
>
> Hmm.  Maybe a better option is to just add a flag to never defer
> ->queue_rq to a workqueue and let drivers handle the it?

That should work, but might lose potential merge benefit of defer.


Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/