Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
From: Lee Jones
Date: Mon Nov 03 2014 - 07:26:13 EST
On Fri, 24 Oct 2014, Dmitry Torokhov wrote:
> On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >
> > > This adds the register offsets for pull up/down for the STMPE
> > > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> > > and keypad lines.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > > ---
> > > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> > > patch series through the input tree, where the registers need to be
> > > used to enable the keypad on the STMPE2401.
> > > ---
> > > drivers/mfd/stmpe.c | 4 ++++
> > > drivers/mfd/stmpe.h | 3 +++
> > > include/linux/mfd/stmpe.h | 2 ++
> > > 3 files changed, 9 insertions(+)
> >
> > Does this need to go in with the other patches in the set?
> >
> > I'm _guessing_ that, as you've sent them separately, they can be
> > applied separately?
> >
> > This needs to go in via MFD, but for my own reference:
> >
> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> The new register definitions are needed for patch #3. If you insist on
> this going through MFD then please take the other 2 patches with my Ack
> through MFD tree as well I do not think we need the whole song and dance
> trying to synchronize 2 trees.
Actually, I can't see the other patches as they weren't sent to me.
Please apply them all to your tree with my Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/