Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
From: Lee Jones
Date: Mon Nov 03 2014 - 07:57:44 EST
On Mon, 03 Nov 2014, Linus Walleij wrote:
> On Wed, Oct 29, 2014 at 8:31 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote:
> >> On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> >> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >> >> This adds the register offsets for pull up/down for the STMPE
> >> >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> >> >> and keypad lines.
> >> >>
> >> >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >> >> ---
> >> >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> >> >> patch series through the input tree, where the registers need to be
> >> >> used to enable the keypad on the STMPE2401.
> >> >> ---
> >> >>
> >> >> drivers/mfd/stmpe.c | 4 ++++
> >> >> drivers/mfd/stmpe.h | 3 +++
> >> >> include/linux/mfd/stmpe.h | 2 ++
> >> >> 3 files changed, 9 insertions(+)
> >> >
> >> > Does this need to go in with the other patches in the set?
> >> >
> >> > I'm _guessing_ that, as you've sent them separately, they can be
> >> > applied separately?
> >>
> >> No sorry if it was unclear, the series need to go in toghether.
> >> So this patch adds some infrastructure to the MFD device which
> >> is then utilized by the input driver in a later patch.
> >>
> >> > This needs to go in via MFD, but for my own reference:
> >> >
> >> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> >>
> >> Dmitry can you merge this & the rest with Lee's ACK?
> >
> > I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD?
>
> Lee, can Dmitry take these through input?
That was weird, I replied at the same as as you sent this.
Yes, it's fine.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/