Re: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio

[Joe Perches]

On Mon, 2014-11-03 at 15:17 +0100, Takashi Iwai wrote:
> At Mon,  3 Nov 2014 16:04:12 +0530,
> Sudip Mukherjee wrote:
> > 
> > added reference of struct echoaudio to free_firmware function.
> > this structure will be later used to get a reference of the card
> > when converting snd_printk to dev_* in the next patch of the series.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> 
> Thanks, now applied both.  Though, I noticed that there is also a
> dev_notice() usage that should be also dev_dbg().  Corrected such
> lines in my side.

Are any of these changes going to cause a
null pointer dereference of chip->card->dev?

ftrace exists and is generic.

Several of these seem to be function tracing
style uses and should just be deleted instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/