Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's
From: Felipe Balbi
Date: Mon Nov 03 2014 - 13:06:41 EST
On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote:
> On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote:
> > From: George Cherian <george.cherian@xxxxxx>
> >
> > Convert the driver to use gpiod_* API's.
> >
> > Reviewed-by: Roger Quadros <rogerq@xxxxxx>
> > Signed-off-by: George Cherian <george.cherian@xxxxxx>
> > Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
>
> I think it might be useful and appropriate to explain that and why
> you remove support for active-low pins, instead of hiding it in a
> seemingly unrelated patch.
removed ? why removed ? gpio descs handle that for you, read the source
code.
--
balbi
Attachment:
signature.asc
Description: Digital signature