Re: [PATCH v8 08/10] sched: add SD_PREFER_SIBLING for SMT level

[Wanpeng Li]

Hi Vincent,
On 14/10/31 äå4:47, Vincent Guittot wrote:
> Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that
> the scheduler will put at least 1 task per core.

What's the behavior before this patch?

Regards,
Wanpeng Li

> Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Reviewed-by: Preeti U. Murthy <preeti@xxxxxxxxxxxxxxxxxx>
> ---
>   kernel/sched/core.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 37fb92c..731f2ad 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6165,6 +6165,7 @@ sd_init(struct sched_domain_topology_level *tl, int cpu)
>   	 */
>   
>   	if (sd->flags & SD_SHARE_CPUCAPACITY) {
> +		sd->flags |= SD_PREFER_SIBLING;
>   		sd->imbalance_pct = 110;
>   		sd->smt_gain = 1178; /* ~15% */
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/